[
https://issues.apache.org/jira/browse/ARTEMIS-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010804#comment-16010804
]
ASF GitHub Bot commented on ARTEMIS-1164:
-----------------------------------------
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1270
ARTEMIS-1164: NameNotFoundException java.naming.provider.url to set url via
jndi
Support setting PROVIDER_URL on initial context to create default
connection factories. To match documentation
https://activemq.apache.org/artemis/docs/2.0.0/using-jms.html, and also
behaviour that existed in ActiveMQ 5.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis
ARTEMIS-1164
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1270
----
commit 7f1885563979522302f217184c8e5f8014acdf82
Author: Michael Andre Pearce <michael.andre.pea...@me.com>
Date: 2017-05-15T16:23:52Z
ARTEMIS-1164: NameNotFoundException when using java.naming.provider.url to
set url via jndi
Support setting PROVIDER_URL on initial context to create default
connection factories.
----
> NameNotFoundException when using java.naming.provider.url to set url via jndi
> ------------------------------------------------------------------------------
>
> Key: ARTEMIS-1164
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1164
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Michael Andre Pearce
>
> It should be possible to create a connection factory via JNDI simply defining
> the initial context factory and provider url.
> {noformat}
> java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory
> java.naming.provider.url=tcp://localhost:5445?type=CF
> {noformat}
> As per samples in docs.
> https://activemq.apache.org/artemis/docs/2.0.0/using-jms.html
> This does not seems to be the case, see below test to prove this.
> {code:java}
> @Test
> public void providerURLTest() throws NamingException {
> String url = "(tcp://somehost:62616,tcp://somehost:62616)?ha=true";
>
> Properties props = new Properties();
> props.setProperty(javax.naming.Context.INITIAL_CONTEXT_FACTORY,
> ActiveMQInitialContextFactory.class.getName());
> props.setProperty(javax.naming.Context.PROVIDER_URL, url);
> InitialContext context = new InitialContext(props);
> ConnectionFactory connectionFactory =
> (ConnectionFactory)context.lookup("ConnectionFactory");
> }
> {code}
> It seems and mandatory param (duplicating the required and standard
> java.naming.provider.url),
> {noformat}
> props.setProperty("connectionFactory.ConnectionFactory",url);
> {noformat}
> {code:java}
> @Test
> public void connectionFactoryProperty() throws NamingException {
> String url = "(tcp://somehost:62616,tcp://somehost:62616)?ha=true";
> Properties props = new Properties();
> props.setProperty(javax.naming.Context.INITIAL_CONTEXT_FACTORY,
> ActiveMQInitialContextFactory.class.getName());
> props.setProperty(javax.naming.Context.PROVIDER_URL, url);
> props.setProperty("connectionFactory.ConnectionFactory",url);
> InitialContext context = new InitialContext(props);
> ConnectionFactory connectionFactory =
> (ConnectionFactory)context.lookup("ConnectionFactory");
> }
> {code}
> Either:
> A) the documentation samples need to be changed
> OR
> B) The ActiveMQInitialContextFactory should default register connection
> factory created using java.naming.provider.url as ConnectionFactory.
> I would propose the latter, as this seems to be the way in Active MQ 5 and
> some other technologies.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
