[ https://issues.apache.org/jira/browse/ARTEMIS-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039511#comment-16039511 ]
ASF GitHub Bot commented on ARTEMIS-1206: ----------------------------------------- Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1321 It is indeed validating the same property, that property is the SOLE_CONTAINER capability that is sent in the open frame to indicate the uniqueness of the client ID as being required. What you are testing is the Qpid JMS client specific implementation of the setClientID and how it controls when the open frame is sent. What you aren't testing in the new test is the affect of not specifying a client ID and also the behavior of setClientID through the Connection or no client ID being set and calling connection start. So if you feel you need this particular test case then for completeness I'd argue you test all variations of client ID / no client ID and ConnectionFactory vs Connection setClientID. > [Core JMS Client] Violates JMS Specification - allows two active connections > with same clientid > ----------------------------------------------------------------------------------------------- > > Key: ARTEMIS-1206 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1206 > Project: ActiveMQ Artemis > Issue Type: Bug > Reporter: Michael Andre Pearce > Attachments: JMSDurableConsumerTest2.java, > JMSDurableConsumerTest2.java > > > Currently it is possible to make two completely separate client connections > to the broker, with the same client id. > This was found/raised as a possible bug in Core Client on looking at > differing behaviours between the Core JMS Client and the Qpid AMQP Client. > https://issues.apache.org/jira/browse/ARTEMIS-1205 > Attached is a test case, where by the Qpid Client errors, and the Core Client > does not, executing the same client code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)