[ 
https://issues.apache.org/jira/browse/AMQ-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish closed AMQ-6762.
-----------------------------
    Resolution: Not A Problem

The 5.x code base does not have an official code style specification.  We 
loosely follow the Google style guide but we don't enforce it and never have.  

> Code style issues
> -----------------
>
>                 Key: AMQ-6762
>                 URL: https://issues.apache.org/jira/browse/AMQ-6762
>             Project: ActiveMQ
>          Issue Type: New Feature
>            Reporter: Tianyin Xu
>
> Hi,
> I was trying hard to find the code-style specifications in the current code 
> base,
> but failed (let me know if it's put somewhere).
> I run {{CheckStyle}} on the current code base, and see that the style is very 
> inconsistent.
> Pick 
> {{activemq-client/src/main/java/org/apache/activemq/ActiveMQConnectionFactory.java}}
>  in trunk for example,
> there're 7 lines using {{tab}} for indentation (e.g., Line 1283, 1284) and 
> the rest using {{4 space}}.
> (there are many like this)
> There're also many other inconsistent style issues, such as all different 
> LineLength and redundant import.
> Let me know if you'd like to integrate {{CheckStyle}} or something alike in 
> the Maven build
> (which can rule out such issues)
> btw, I do see a {{CheckStyle}} section in the top-level {{pom.xml}} commented 
> out.
> (is there any specific reasons for that?)
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to