[ 
https://issues.apache.org/jira/browse/ARTEMIS-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130701#comment-16130701
 ] 

ASF GitHub Bot commented on ARTEMIS-1354:
-----------------------------------------

Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1468#discussion_r133750815
  
    --- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java
 ---
    @@ -304,7 +304,7 @@ public void run() {
              try {
                 libaioFile.write(position, bytes, buffer, this);
              } catch (IOException e) {
    -            callback.onError(-1, e.getMessage());
    --- End diff --
    
    NIO should be fixed separately,  I don't want to include change here, since 
the JIRA is specifically about the bug.  NIO change is an enhancement.


> AIOSequentialFile does not call IOError on write failure
> --------------------------------------------------------
>
>                 Key: ARTEMIS-1354
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1354
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Martyn Taylor
>
> This has potential to cause loss of availability, particular in a HA 
> environment as the broker will not shut down when writes are failing due to 
> disk or network failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to