[ 
https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153221#comment-16153221
 ] 

ASF GitHub Bot commented on ARTEMIS-1385:
-----------------------------------------

Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1509#discussion_r136912715
  
    --- Diff: docs/user-manual/en/configuration-index.md ---
    @@ -112,7 +112,7 @@ system-property-prefix | Prefix for replacing 
configuration settings using Bean
     [transaction-timeout](transaction-config.md "Resource Manager 
Configuration")              |  how long (in ms) before a transaction can be 
removed from the resource manager after create time. Default=300000
     [transaction-timeout-scan-period](transaction-config.md "Resource Manager 
Configuration")  |  how often (in ms) to scan for timeout transactions. 
Default=1000
     [wild-card-routing-enabled](wildcard-routing.md "Routing Messages With 
Wild Cards")        |  true means that the server supports wild card routing. 
Default=true
    -[network-check-NIC](network-isolation.md) | The network internet card to 
be used on InetAddress.isReacheable
    +[network-check-NIC](network-isolation.md) | The network internet 
controller to be used on InetAddress.isReacheable
    --- End diff --
    
    NIC is Network Interface Controller. I had to google that and I guess it 
won't be obvious to more people. Maybe write the abbreviation and the meaning 
in parens after it, so that people learn this right away.
    
    Also, it may not be entirely obvious what are the NIC names. Something like 
eth0 on Linux? What it is on Windows? How can I list them? Any alternatives to 
this for older systems, that do not have the more robust "enp0s25" style naming 
and eth0 and eth1 may be randomly switched; or is that no longer a problem?


> Incomplete comment in default broker.xml file
> ---------------------------------------------
>
>                 Key: ARTEMIS-1385
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1385
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Martyn Taylor
>
>       <!--
>         You can specify the NIC you want to use to verify if the network
>          <network-check-NIC>theNickName</network-check-NIC>
>         -->



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to