[ 
https://issues.apache.org/jira/browse/ARTEMIS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212702#comment-16212702
 ] 

ASF GitHub Bot commented on ARTEMIS-1471:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1600#discussion_r145976943
  
    --- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedFile.java
 ---
    @@ -301,23 +206,24 @@ public void zeros(int position, final int count) 
throws IOException {
           if (toZeros > 0) {
              PlatformDependent.setMemory(start, toZeros, (byte) 0);
           }
    -
    +      //do not move position!
    --- End diff --
    
    I don't understand this comment... you are moving position and writing do 
not move?


> Needs Bounds Checking on writes for MappedSequentialFile
> --------------------------------------------------------
>
>                 Key: ARTEMIS-1471
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1471
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to