[ https://issues.apache.org/jira/browse/ARTEMIS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221087#comment-16221087 ]
ASF GitHub Bot commented on ARTEMIS-1447: ----------------------------------------- Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1576#discussion_r147246049 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/ScheduledLeaseLock.java --- @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.activemq.artemis.core.server.impl.jdbc; + +import java.util.concurrent.ScheduledExecutorService; + +import org.apache.activemq.artemis.core.io.IOCriticalErrorListener; +import org.apache.activemq.artemis.core.server.ActiveMQComponent; +import org.apache.activemq.artemis.utils.actors.ArtemisExecutor; + +/** + * {@link LeaseLock} holder that allows to schedule a {@link LeaseLock#renew} task with a fixed {@link #renewPeriodMillis()} delay. + */ +interface ScheduledLeaseLock extends ActiveMQComponent { + + LeaseLock lock(); + + long renewPeriodMillis(); + + static ScheduledLeaseLock of(ScheduledExecutorService scheduledExecutorService, --- End diff -- @franz1981 the only thing I didn't like was the name of this method :) I would have chosen build.. newInstance... But I will take it as a personal choice.. will just merge it 👍 > JDBC NodeManager to support JDBC HA Shared Store > ------------------------------------------------ > > Key: ARTEMIS-1447 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1447 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker > Reporter: Francesco Nigro > Assignee: Francesco Nigro > -- This message was sent by Atlassian JIRA (v6.4.14#64029)