[
https://issues.apache.org/jira/browse/ARTEMIS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276435#comment-16276435
]
ASF GitHub Bot commented on ARTEMIS-1532:
-----------------------------------------
Github user jdanekrh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1683
Well, I might've guessed the intent wrong in one or two cases, I guess.
If I thought it is unintentional, I've either renamed the class (so that
Surefire would pick it) or added the @Test annotation.
If I thought it is intentional, I've added @Ignored annotation instead of
whichever other method was used to disable that test.
> Enable tests which are unintentionally skipped by surefire
> ----------------------------------------------------------
>
> Key: ARTEMIS-1532
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1532
> Project: ActiveMQ Artemis
> Issue Type: Test
> Components: Broker, STOMP
> Affects Versions: 1.5.6, 2.5.0
> Reporter: Jiri Daněk
> Assignee: Justin Bertram
>
> Some tests, e.g.
> {{org.apache.activemq.artemis.tests.integration.stomp#StompTestWithInterceptors}}
> are not being run by Maven.
> This is because by default the Surefire Maven plugin searches for tests in
> classes with a certain name pattern. These tests are not named to conform to
> this pattern.
> https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html
> There are some tests which have a conforming name, but it is not *Test.java,
> which seems to be the chosen Artemis convention. These are
> {noformat}
> org.apache.activemq.advisory.AdvisoryTests
> org.apache.activemq.artemis.tests.integration.amqp.TopicDurableTests
> org.apache.activemq.usecases.DurableSubscriptionHangTestCase
> org.apache.activemq.usecases.TestBrokerConnectionDuplexExcludedDestinations
> org.apache.activemq.artemis.tests.smoke.expire.TestSimpleExpire
> {noformat}
> CC [~clebertsuconic]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
