[
https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318665#comment-16318665
]
ASF GitHub Bot commented on ARTEMIS-1590:
-----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1756#discussion_r160451205
--- Diff: artemis-jdbc-store/src/main/resources/journal-sql.properties ---
@@ -0,0 +1,63 @@
+# Generic SQL statements
--- End diff --
It is needed to add on top:
```
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
```
> Use properties to configure JDBC store SQLProvider
> --------------------------------------------------
>
> Key: ARTEMIS-1590
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1590
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Jeff Mesnil
>
> This follow up the conversation started on activemq-dev mailing list[1] to
> use a properties-based implementation for Artemis SQLProvider to ease
> maintenance and support of different databases and their dialects.
> [1]
> http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
