[ https://issues.apache.org/jira/browse/ARTEMIS-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322062#comment-16322062 ]
ASF GitHub Bot commented on ARTEMIS-1601: ----------------------------------------- GitHub user jostbg opened a pull request: https://github.com/apache/activemq-artemis/pull/1772 ARTEMIS-1601 Prevent NPE in StompSession#sendMessage You can merge this pull request into a Git repository by running: $ git pull https://github.com/jostbg/activemq-artemis ARTEMIS-1601 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1772.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1772 ---- commit 185983d4dff8e9d256fc65cb2e1fe0e7b12ec8fb Author: jostbg <35264802+jostbg@...> Date: 2018-01-11T11:16:35Z ARTEMIS-1601 Prevent NPE in StompSession#sendMessage ---- > NPE silently thrown in StompSession#sendMessage > ----------------------------------------------- > > Key: ARTEMIS-1601 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1601 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: STOMP > Affects Versions: 2.4.0 > Environment: Artemis 2.5.0-SNAPSHOT > Reporter: Johan Stenberg > Assignee: Justin Bertram > > During debugging a stomp session I realized that the StompSession's send > method does not check if looking up a subscription returns null: > {code:java} > StompSubscription subscription = subscriptions.get(consumer.getID()); > {code} > This later sometimes results NPEs at: > {code:java} > if (subscription.getAck().equals(Stomp.Headers.Subscribe.AckModeValues.AUTO)) > { > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)