[ 
https://issues.apache.org/jira/browse/ARTEMIS-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330559#comment-16330559
 ] 

ASF GitHub Bot commented on ARTEMIS-1577:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1787#discussion_r162353710
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ---
    @@ -736,11 +736,11 @@ public RoutingStatus route(final Message message,
              throw new IllegalStateException("Message cannot be routed more 
than once");
           }
     
    -      setPagingStore(message);
    +      setPagingStore(context.getAddress(message), message);
     
           AtomicBoolean startedTX = new AtomicBoolean(false);
     
    -      final SimpleString address = message.getAddressSimpleString();
    +      final SimpleString address = context.getAddress(message);
    --- End diff --
    
    I'm just going for the simple refactoring here.. every call to 
message.getAddressSimplString() to be calling context.getAddress()



> Address-full-policy isn't being applied properly for 1.x JMS client
> -------------------------------------------------------------------
>
>                 Key: ARTEMIS-1577
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1577
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Shailendra Kumar singh
>            Priority: Major
>         Attachments: broker.xml
>
>
> Address-settings policies aren't being applied when using an older version of 
> JMS client.
> Example:-
> #broker.xml
> {code:java}
> <address-setting match="exampleQueue">
>                 <address-full-policy>FAIL</address-full-policy>
>                 <max-size-bytes>10</max-size-bytes>
>  </address-setting>
> {code}
> When using JMS client(artemis-jms-client) version 1.5.5, Address-settings 
> policies are not applied.
> When using latest client version, it works as expected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to