[ https://issues.apache.org/jira/browse/ARTEMIS-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335306#comment-16335306 ]
ASF GitHub Bot commented on ARTEMIS-1626: ----------------------------------------- Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1800 Right now it fails the test. If you changed it to log only if the test failed. You got what you wanted. And what we wanted. It’s a good compromise. > Disable thread leak check for failing tests > ------------------------------------------- > > Key: ARTEMIS-1626 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1626 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker > Affects Versions: 2.4.0 > Reporter: Howard Gao > Assignee: Howard Gao > Priority: Major > Fix For: 2.5.0 > > > The ThreadLeakCheckRule is used to check thread leaks > after each test is finished. However when a test fails, it is > not necessary to check leaking threads because the test > failure should be fixed anyway. And leaking threads in a > failed test may well be a result of the failure (once the test > is fixed the thread leak may be gone). > If a failed test also leaks threads, it takes a long time before > the thread leak check finishes (60 seconds checking time), > thus it takes a long time to finish, especially when tests are > run in batches with failures. > So to improve this, it should be reasonable to just enable > the thread leaking check for each test passes, and disable > the check when a test fails. -- This message was sent by Atlassian JIRA (v7.6.3#76005)