[ https://issues.apache.org/jira/browse/ARTEMIS-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366765#comment-16366765 ]
ASF GitHub Bot commented on ARTEMIS-1653: ----------------------------------------- Github user nlippke commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1822#discussion_r168707901 --- Diff: artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcLeaseLockTest.java --- @@ -33,13 +35,31 @@ import org.junit.Assert; import org.junit.Before; import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; +import org.junit.runners.Parameterized.Parameter; +@RunWith(Parameterized.class) public class JdbcLeaseLockTest extends ActiveMQTestBase { private JdbcSharedStateManager jdbcSharedStateManager; private DatabaseStorageConfiguration dbConf; private SQLProvider sqlProvider; + @Parameterized.Parameters(name = "create_tables_prior_test") + public static List<Object[]> data() { + return Arrays.asList(new Object[][] { + {true, null}, + {false, null} + }); + } + + @Parameter(0) + public boolean withExistingTable; + @Parameter(1) + public Object result; --- End diff -- Your version of Junit requires to work with tuples (input, expecte result). Newer versions allow input only. If you don't have this annotation JUnit will complain. > Allow database tables to be created externally > ---------------------------------------------- > > Key: ARTEMIS-1653 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1653 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker > Affects Versions: 2.4.0 > Reporter: Niels Lippke > Priority: Major > > In some environments (e.g. production) it is not allowed that applications > create their own schema. It's common practice to pass DDL-Statetements to > DBAs instead prior to rollout. > Currently the broker does not support this scenario. If the required tables > already exist the broker fails to start. > A better approach is that if the broker detects empy tables and initializes > them in the very same way it does if the tables dont't exist. > See also discussion in > [forum|http://activemq.2283324.n4.nabble.com/ARTEMIS-Server-doesn-t-start-if-JDBC-store-is-used-and-table-NODE-MANAGER-STORE-is-empty-td4735779.html]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)