[
https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374921#comment-16374921
]
ASF GitHub Bot commented on ARTEMIS-1700:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170355937
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
beforeStart();
- singleThreadExecutor = executorFactory.getExecutor();
+ ThreadFactory tFactory = AccessController.doPrivileged(new
PrivilegedAction<ThreadFactory>() {
+ @Override
+ public ThreadFactory run() {
+ return new ActiveMQThreadFactory("ActiveMQ-journal-server-" +
this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
+ }
+ });
+ singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
--- End diff --
nope.. that's wrong...
executorFactory.getExecutor() is returning on thread executor from the pool.
it won't always be the same thread.. but it will always be the same
context.. this patch is not valid.
in what situation do you see a deadlock.
hornetq it might be different.. I would need a test to be able to accept a
patch here. we should reuse the thread from the pool always.
> Server stopped responding and killed itself while exiting paging state
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-1700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1700
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Qihong Xu
> Priority: Major
> Attachments: artemis.log
>
>
> We are currently experiencing this error while running stress test on artemis.
>
> Basic configuration:
> 1 broker ,1 topic, pub-sub mode.
> Journal type = MAPPED.
> Threadpool max size = 60.
>
> In order to test the throughput of artemis we use 300 producers and 300
> consumers. However we found that sometimes when artemis exit paging state, it
> will stop responding and kill itself. This situatuion happened on some
> specific servers.
>
> Details can be found in attached dump file.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
