Robbie Gemmell created ARTEMIS-1862:
---------------------------------------
Summary: fix acceptor config default for 'amqpLowCredits' and
update related code defaults
Key: ARTEMIS-1862
URL: https://issues.apache.org/jira/browse/ARTEMIS-1862
Project: ActiveMQ Artemis
Issue Type: Bug
Components: AMQP
Affects Versions: 2.5.0
Reporter: Robbie Gemmell
The brokers AMQP protocol support has configurable 'amqpCredits' and
'amqpLowCredits' values to govern the amount of credit given to a producer at a
time and when it is refreshed. The broker.xml files appears to set these to
values of 1000 and 300 respectively by default, while the code has default
values of 100 and 30 instead.
The XML configuration for the 'amqp' acceptor (using the AMQP port, 5672) has
incorrectly had the value 'amqpMinCredits' applied rather than 'amqpLowCredits'
as required and used on the 'artemis' acceptor, and as result this has no
effect and the codes fallback of 30 gets used instead. This results in the
broker waiting until it has processed very nearly every message a producer
could have sent with the outstanding credit before sending any new credit,
meaning producers with reasonable throughput will likely get stalled awaiting
more credit repeatedly.
The change in the coming PR corrects the XML config, changes the code to use
the same values as this for a consistent default, and adds a test to verify the
default credit refresh behaviour is as expected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
