[ https://issues.apache.org/jira/browse/ARTEMIS-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628292#comment-16628292 ]
ASF GitHub Bot commented on ARTEMIS-2095: ----------------------------------------- Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2328 @michaelandrepearce Michael, you know that I love doing perf stuff as well, so I can share some bench with JMH as soon as I would find some minutes during the day (or this evening) :+1: On Proton-j we have a module with all the JMH benchs, probably having something similar on Artemis will avoid writing new ones every time... > TypedProperties thread safety > ----------------------------- > > Key: ARTEMIS-2095 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2095 > Project: ActiveMQ Artemis > Issue Type: Bug > Reporter: Michael Andre Pearce > Assignee: Michael Andre Pearce > Priority: Major > > Whilst TypedProperties is meant to have a single thread acting on it (and > this is the most typical interaction), there are occurrences where, it can be > acted on by other threads, when this occurs some concurrent modification > errors can occur. > As such TypedProperties must be thread safe, but concurrency tuning should > factor in to be most performant for single thread. > > e.g. > 2018-09-24 15:01:27,751 WARN > [org.apache.activemq.artemis.core.message.impl.CoreMessage] Error creating > String for message: : java.util.ConcurrentModificationException at > java.util.HashMap$HashIterator.nextNode(HashMap.java:1437) [rt.jar:1.8.0_102] > at java.util.HashMap$EntryIterator.next(HashMap.java:1471) [rt.jar:1.8.0_102] > at java.util.HashMap$EntryIterator.next(HashMap.java:1469) [rt.jar:1.8.0_102] > at > org.apache.activemq.artemis.utils.collections.TypedProperties.toString(TypedProperties.java:464) -- This message was sent by Atlassian JIRA (v7.6.3#76005)