[ https://issues.apache.org/jira/browse/ARTEMIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642669#comment-16642669 ]
ASF GitHub Bot commented on ARTEMIS-2094: ----------------------------------------- GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2354 ARTEMIS-2094 Capture SecurityRepository changes to server config This fixes SecurityFailoverTest and any other test that only updates security repository and not the config. You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-2094-enhancement Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2354.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2354 ---- commit 9d76d0588dd7d4eb12e1191368e1ca725da95b2d Author: Michael André Pearce <michael.andre.pearce@...> Date: 2018-10-08T23:35:52Z ARTEMIS-2094 Capture SecurityRepository changes to server config This fixes SecurityFailoverTest and any other test that only updates security repository and not the config. ---- > Configuration change loss after failover to slave > ------------------------------------------------- > > Key: ARTEMIS-2094 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2094 > Project: ActiveMQ Artemis > Issue Type: Bug > Affects Versions: 2.6.3 > Reporter: Michael Andre Pearce > Assignee: Michael Andre Pearce > Priority: Major > > This is further cases discovered during testing network failures. > Essentially we have noticed when config settings are reloaded such as > address-setting or security-setting, the live node correctly reloads, but > after live failure the backup activates, the backup does not contain these > changes due to the configuration object held inside ActiveMQServerImpl is out > of date to when the backup server first started. > so further enhancements/bug fixes on top of ARTEMIS-1747 - Fix Configuration > change loss when network Issue. which fixed this for an active node. > Essentially we just need to keep the updating of the configuration object in > ActiveMQServerImpl outside the isActive check. > Also address-settings and security settings should be swap'd during > initialisation phase 2, so these are set to latest config after activation. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)