[ https://issues.apache.org/jira/browse/ARTEMIS-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711551#comment-16711551 ]
ASF GitHub Bot commented on ARTEMIS-2189: ----------------------------------------- Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2448#discussion_r239482834 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -386,14 +386,27 @@ public void setSimpleAddress(SimpleString address) { public void delete() throws JMSException { if (session != null) { + ActiveMQSession sessionToUse = session; + boolean temporary = false; if (session.getCoreSession().isClosed()) { - // Temporary queues will be deleted when the connection is closed.. nothing to be done then! - return; + /** --- End diff -- @tabish121 The updated version is fine mate? If is fine I will merge it :+1: > Allow deleting temporary destination when originating session is closed > ----------------------------------------------------------------------- > > Key: ARTEMIS-2189 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2189 > Project: ActiveMQ Artemis > Issue Type: Bug > Affects Versions: 2.6.3 > Reporter: Justin Bertram > Assignee: Justin Bertram > Priority: Major > > If a client closes its JMS session (intentionally or not) and then invokes > {{javax.jms.TemporaryQueue.delete()}} or > {{javax.jms.TemporaryTopic.delete()}} these methods will return without > actually deleting the destination (because the underlying session was > closed). The JMS spec states that the lifetime of a temporary destination is > tied to the connection rather than the session so even after the session is > closed it should still be possible to delete the temporary destination. -- This message was sent by Atlassian JIRA (v7.6.3#76005)