[ 
https://issues.apache.org/jira/browse/ARTEMIS-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719969#comment-16719969
 ] 

ASF GitHub Bot commented on ARTEMIS-2201:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2460
  
    @mnovak1 @feuillemorte `JournalFilesRepository.journalFileOpenTimeout` 
isn't public or exposed by any getter hence to check it can be done in 2 ways:
    
    1. using a mock to intercept it when created
    2. exposing it with a getter on `JournalFilesRepository` so it can be 
verified
    
    AFAIK we are not doing it for the other classes, so I think it can be 
avoided.
    But if we have some good reason to do it, @feuillemorte can find a proper 
way to do it :+1: 


> Create tests on DEFAULT_JOURNAL_FILE_OPEN_TIMEOUT value
> -------------------------------------------------------
>
>                 Key: ARTEMIS-2201
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2201
>             Project: ActiveMQ Artemis
>          Issue Type: Test
>          Components: Broker
>            Reporter: Oleg Sushchenko
>            Priority: Major
>
> Need to create tests to cover changing variable 
> DEFAULT_JOURNAL_FILE_OPEN_TIMEOUT to another value which is not equals 
> default value



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to