[
https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=187897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187897
]
ASF GitHub Bot logged work on ARTEMIS-2170:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/19 20:31
Start Date: 21/Jan/19 20:31
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on issue #2427:
ARTEMIS-2170 Optimized CoreMessage's checkProperties and
cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456191677
Just test core message in isolation franz. If an internal header is not
present it will not iterate through. This needs to be kept. As ive suggested
earlier maybe these special headers should go into extra properties that are
kept in a seperate typed properties a bit like what is done for amqp message.
But currently without doing anything i cant give this a +1 as messages without
any internal properties currently dont need them iterated at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 187897)
Time Spent: 3.5h (was: 3h 20m)
> Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-2170
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2170
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> CoreMessage::checkProperties perform too many volatile read/write and has a
> too big body just to handle exceptional cases, while
> cleanupInternalProperties is called on the hot path of session send, but is
> performing too many synchronized operations and loopup on TypedProperties.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
