[ https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=188024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188024 ]
ASF GitHub Bot logged work on ARTEMIS-2170: ------------------------------------------- Author: ASF GitHub Bot Created on: 22/Jan/19 08:33 Start Date: 22/Jan/19 08:33 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456313267 Once/if you merge that, my concern on this PR is removed, and im +1 and will be happy to merge ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 188024) Time Spent: 5.5h (was: 5h 20m) > Optimized CoreMessage's checkProperties and cleanupInternalProperties methods > ----------------------------------------------------------------------------- > > Key: ARTEMIS-2170 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2170 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker > Reporter: Francesco Nigro > Assignee: Francesco Nigro > Priority: Minor > Time Spent: 5.5h > Remaining Estimate: 0h > > CoreMessage::checkProperties perform too many volatile read/write and has a > too big body just to handle exceptional cases, while > cleanupInternalProperties is called on the hot path of session send, but is > performing too many synchronized operations and loopup on TypedProperties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)