[
https://issues.apache.org/jira/browse/ARTEMIS-2239?focusedWorklogId=190356&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190356
]
ASF GitHub Bot logged work on ARTEMIS-2239:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/19 08:41
Start Date: 26/Jan/19 08:41
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2522: ARTEMIS-2239
Zero-copy NIO/MAPPED TimedBuffer
URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251192771
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFile.java
##########
@@ -301,21 +269,19 @@ protected ByteBuffer newBuffer(int size, int limit) {
protected class LocalBufferObserver implements TimedBufferObserver {
Review comment:
It is not easy: it's `Local` to the owner class in the worst way: it use
directly private files as `fileSize` that has a very tricky semantic around. I
prefer to left it to stay where it is to reduce the amount of changes.
I could put it as package private class, but that means to expose (on
package level) some internals of `AbstractSequentialFile` that's not a good
idea IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 190356)
Time Spent: 4h (was: 3h 50m)
> Zero-copy NIO/MAPPED TimedBuffer
> --------------------------------
>
> Key: ARTEMIS-2239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2239
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.6.4
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> NIO/MAPPED journal types are currently performing the copy of the buffer used
> on TimedBuffer to accumulate writes, but this copy (and the zeroing of the
> new buffer) could be avoided, reducing dramatically the CPU usage and
> latencies during a burst of writes.
> An added benefit of this change is that isn't necessary anymore to stress the
> thread pool of the file factory, because there is no need to pool the buffer
> used to perform the write.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
