[ 
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=194532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194532
 ]

ASF GitHub Bot logged work on ARTEMIS-2226:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Feb/19 14:22
            Start Date: 05/Feb/19 14:22
    Worklog Time Spent: 10m 
      Work Description: onlyMIT commented on pull request #2528: ARTEMIS-2226 
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253882381
 
 

 ##########
 File path: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ##########
 @@ -47,7 +47,8 @@
    SESSION_CREATED(26),
    SESSION_CLOSED(27),
    MESSAGE_DELIVERED(28),
-   MESSAGE_EXPIRED(29);
+   MESSAGE_EXPIRED(29),
+   CONNECTION_CONNECTED(30);
 
 Review comment:
   ```
   private void handleNotificationMessage(ClientMessage message, 
CoreNotificationType ntype) throws Exception {
            // TODO - optimised this by just passing int in header - but filter 
needs to be extended to support IN with
   
            switch (ntype) {
               case BINDING_ADDED: {
                  doBindingAdded(message);
   
                  break;
               }
               case BINDING_REMOVED: {
                  doBindingRemoved(message);
   
                  break;
               }
               case CONSUMER_CREATED: {
                  doConsumerCreated(message);
   
                  break;
               }
               case CONSUMER_CLOSED: {
                  doConsumerClosed(message);
   
                  break;
               }
               case PROPOSAL: {
                  doProposalReceived(message);
   
                  break;
               }
               case PROPOSAL_RESPONSE: {
                  doProposalResponseReceived(message);
                  break;
               }
               case UNPROPOSAL: {
                  doUnProposalReceived(message);
                  break;
               }
               default: {
                  throw ActiveMQMessageBundle.BUNDLE.invalidType(ntype);
               }
            }
         }
   ```
   
   Only these notifications will pass between cluster nodes
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 194532)
    Time Spent: 17.5h  (was: 17h 20m)

> (MQTT)In the cluster,the last consumer connection should close the previous 
> consumer connection
> -----------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2226
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Shiping Liang
>            Priority: Major
>          Time Spent: 17.5h
>  Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer 
> connection should close the previous consumer connection!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to