[ 
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=197512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197512
 ]

ASF GitHub Bot logged work on ARTEMIS-2226:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Feb/19 11:56
            Start Date: 12/Feb/19 11:56
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on pull request #2528: 
ARTEMIS-2226 last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255920956
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
 ##########
 @@ -2954,7 +2955,13 @@ public void 
onNotification(org.apache.activemq.artemis.core.server.management.No
       if (!(notification.getType() instanceof CoreNotificationType))
          return;
       CoreNotificationType type = (CoreNotificationType) 
notification.getType();
-      TypedProperties prop = notification.getProperties();
+      if (type == CoreNotificationType.SESSION_CREATED) {
+         TypedProperties props = notification.getProperties();
+         //SESSION_CREATED notification should not be broadcast twice
+         if (props.getIntProperty(ManagementHelper.HDR_DISTANCE) > 0) {
 
 Review comment:
   Also isnt cyclic between nodes in cluster already avoided, because of filter 
in the cluster connection bridge where it does a HDR_DISTANCE < flow.maxHops.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 197512)
    Time Spent: 20h 40m  (was: 20.5h)

> (MQTT)In the cluster,the last consumer connection should close the previous 
> consumer connection
> -----------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2226
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Shiping Liang
>            Priority: Major
>          Time Spent: 20h 40m
>  Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer 
> connection should close the previous consumer connection!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to