[
https://issues.apache.org/jira/browse/ARTEMIS-2251?focusedWorklogId=201044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201044
]
ASF GitHub Bot logged work on ARTEMIS-2251:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 02:22
Start Date: 20/Feb/19 02:22
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2549:
ARTEMIS-2251 Large messages might not be deleted when server crashed
URL: https://github.com/apache/activemq-artemis/pull/2549#discussion_r258310314
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
##########
@@ -432,7 +432,7 @@ public void freeDirectBuffer(ByteBuffer buffer) {
journalFF.releaseBuffer(buffer);
}
- public long storePendingLargeMessage(final long messageID, long recordID)
throws Exception {
Review comment:
There is diff between a memory block and an waiting on disk io.
Can this not be async in a different thread with a callback with a response
later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 201044)
Time Spent: 1h (was: 50m)
> Large messages might not be deleted when server crashed
> -------------------------------------------------------
>
> Key: ARTEMIS-2251
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2251
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Qihong Xu
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When deleting large messages, artemis will use storePendingLargeMessage to
> insert a temporary record in journal for reload, in case server crashed and
> large messages stayed forever. But in storePendingLargeMessage that
> appendAddRecord inserts records asynchronously. In this way there are
> potential risks that tasks in executor get lost due to server crash, which
> may lead to undeletable large messages. To solve this problem a Boolean is
> added to storePendingLargeMessage so that it will be forced to use
> SimpleWaitIOCallback in delete situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
