[
https://issues.apache.org/jira/browse/ARTEMIS-2336?focusedWorklogId=243962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243962
]
ASF GitHub Bot logged work on ARTEMIS-2336:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/19 11:57
Start Date: 17/May/19 11:57
Worklog Time Spent: 10m
Work Description: wy96f commented on pull request #2666: ARTEMIS-2336 Use
zero copy to replicate journal/page/large message file
URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r285094410
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
##########
@@ -385,6 +402,34 @@ public final void write(ActiveMQBuffer buffer,
}
}
+ @Override
+ public void write(ActiveMQBuffer buffer,
Review comment:
Do you mean we call write twice, first write buffer api, second new write
file api in channel::send()? This way we will call netty channel::writeAndFlush
twice, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 243962)
Time Spent: 5h 40m (was: 5.5h)
> Use zero copy to replicate journal/page/large message file
> ----------------------------------------------------------
>
> Key: ARTEMIS-2336
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2336
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: yangwei
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> Use sendfile to replicate files during backup sever bootstrap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
