[ 
https://issues.apache.org/jira/browse/ARTEMIS-2308?focusedWorklogId=249424&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249424
 ]

ASF GitHub Bot logged work on ARTEMIS-2308:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/May/19 15:16
            Start Date: 28/May/19 15:16
    Worklog Time Spent: 10m 
      Work Description: franz1981 commented on pull request #2681: ARTEMIS-2308 
Support exporting metrics
URL: https://github.com/apache/activemq-artemis/pull/2681#discussion_r288159636
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AddressInfo.java
 ##########
 @@ -191,4 +194,16 @@ public long getUnRoutedMessageCount() {
       return unRoutedMessageCountUpdater.get(this);
    }
 
+   public void registerMeters(MetricsManager metricsManager) {
+      if (metricsManager != null) {
+         metricsManager.registerAddressGauge("routed.message.count", 
name.toString(), this, metrics -> Double.valueOf(getRoutedMessageCount()), 
AddressControl.ROUTED_MESSAGE_COUNT_DESCRIPTION);
+         metricsManager.registerAddressGauge("unrouted.message.count", 
name.toString(), this, metrics -> Double.valueOf(getUnRoutedMessageCount()), 
AddressControl.ROUTED_MESSAGE_COUNT_DESCRIPTION);
+      }
+   }
+
+   public void unregisterMeters(MetricsManager metricsManager) {
+      if (metricsManager != null) {
 
 Review comment:
   Ups sorry, reading it from the web I haven't noticed from where 
`metricsManager` was coming
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 249424)
    Time Spent: 8h 20m  (was: 8h 10m)

> Support exporting metrics
> -------------------------
>
>                 Key: ARTEMIS-2308
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2308
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>    Affects Versions: 2.7.0
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 8h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to