[
https://issues.apache.org/jira/browse/ARTEMIS-2394?focusedWorklogId=267995&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-267995
]
ASF GitHub Bot logged work on ARTEMIS-2394:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/19 21:27
Start Date: 26/Jun/19 21:27
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2727:
ARTEMIS-2394 Improve scheduling sync for AMQPConnectionContext
URL: https://github.com/apache/activemq-artemis/pull/2727#discussion_r297873992
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
##########
@@ -87,9 +89,8 @@
private final boolean useCoreSubscriptionNaming;
- private boolean isSchedulingCancelled;
- private ScheduledFuture scheduledFuture;
- private final Object schedulingLock = new Object();
+ private static final FutureTask<Void> voidFuture = new FutureTask<>(() -> {
}, null);
Review comment:
on that note what is its purpose? surely can just set the reference to null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 267995)
Time Spent: 2h 10m (was: 2h)
> Improve scheduling synchronization for AMQPConnectionContext
> ------------------------------------------------------------
>
> Key: ARTEMIS-2394
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2394
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Bruscino
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Locks in connection stuff, artemis was built on the premise of being
> nonblocking. As time goes on more and more blocking locks are being added to
> core code paths.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
