[
https://issues.apache.org/jira/browse/ARTEMIS-2415?focusedWorklogId=272485&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-272485
]
ASF GitHub Bot logged work on ARTEMIS-2415:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jul/19 08:29
Start Date: 05/Jul/19 08:29
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2741: ARTEMIS-2415
JDBCJournal miss pending tasks during shutdown
URL: https://github.com/apache/activemq-artemis/pull/2741#discussion_r300588314
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
##########
@@ -86,6 +87,8 @@
protected ReplicationManager replicator;
+ protected final AtomicInteger deletingLargeMessageTasks = new
AtomicInteger(0);
Review comment:
I would put this logic just into `JDBCJournalStorageManager` while exposing
here these callbacks:
```java
protected void beforeSubmitDeleteLargeMessageRequest() {
}
protected void afterDeleteLargeMessageCompleted() {
}
protected void afterDeleteLargeMessageError(int code, String errorMessage) {
}
```
The names could be improved, but the idea would be to let just JDBC part to
care about this (unless we know that the storage manager need to handle this
too), wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 272485)
Time Spent: 20m (was: 10m)
> JDBCJournal miss pending tasks during shutdown
> ----------------------------------------------
>
> Key: ARTEMIS-2415
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2415
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Domenico Bruscino
> Priority: Major
> Attachments:
> downstream_run_16.filtered_testRegularMessagePersistenceDelayedConsumer.log
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> If server stops while having pending tasks in OperationContextImpl for
> JDBCJournal, server omits this tasks and prints a bunch of exceptions in the
> log, not exiting cleanly.
> Log of the situation from the test run is attached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
