[
https://issues.apache.org/jira/browse/AMQNET-589?focusedWorklogId=276419&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276419
]
ASF GitHub Bot logged work on AMQNET-589:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jul/19 22:27
Start Date: 14/Jul/19 22:27
Worklog Time Spent: 10m
Work Description: cjwmorgan-sol commented on issue #4: AMQNET-589:
Failover implementation
URL: https://github.com/apache/activemq-nms-amqp/pull/4#issuecomment-511240456
> @cjwmorgan-sol Off topic question. It was a conscious decision not to use
"var" keyword in your original implementation?
No I believe not, I remember an internal discussion about coding style and I
do not recall var ever coming up, maybe @RagnarPaulson knows better?
I think it was more of a personal coding style. There are some good reasons
for and against using the keyword 'var', see
[blog](https://intellitect.com/when-to-use-and-not-use-var-in-c/). At the time
however I think the idea was to write "good descriptive code" for opensource
and at the time, at least to me, using the keyword 'var' did not register to me
as "good descriptive code".
Although now I think the old original implementation could have had a few
benefits from using var based on the aforementioned
[blog](https://intellitect.com/when-to-use-and-not-use-var-in-c/) with maybe a
code style section in the ReadMe.md to explain the desired uses for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 276419)
Time Spent: 6h 10m (was: 6h)
> NMS AMQP Failover implementation
> --------------------------------
>
> Key: AMQNET-589
> URL: https://issues.apache.org/jira/browse/AMQNET-589
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: ActiveMQ, AMQP, NMS
> Affects Versions: 1.8.0
> Reporter: Krzysztof Porebski
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Implement failover in NMS AMQP the same way as it is implemented in QpidJMS.
> This will involve some major rework, as current design is too rigid to
> introduce this feature.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
