[
https://issues.apache.org/jira/browse/ARTEMIS-2322?focusedWorklogId=276818&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276818
]
ASF GitHub Bot logged work on ARTEMIS-2322:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 16:21
Start Date: 15/Jul/19 16:21
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2751:
ARTEMIS-2322: Expose Queue.getRate() data as JMX metric
URL: https://github.com/apache/activemq-artemis/pull/2751#discussion_r303521994
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
##########
@@ -249,6 +249,21 @@ public long getMessageCount() {
}
}
+ @Override
+ public float getProducedRate() {
+ if (AuditLogger.isEnabled()) {
+ AuditLogger.getProducedRate(queue);
+ }
+ checkStarted();
+
+ clearIO();
Review comment:
Shouldnt be doing this on an attribute will cause perf issues when metric
systems scrape blocking deliveries
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 276818)
Time Spent: 20m (was: 10m)
> Expose Queue.getRate() data as JMX metric
> -----------------------------------------
>
> Key: ARTEMIS-2322
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2322
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.8.0
> Reporter: Dmitry Volodin
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It would be nice also to expose metrics from the Queue.getRate() as JMX and
> have to setup window function for calculation (in the future).
> I will try to take care about this features and create PR soon.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
