[ 
https://issues.apache.org/jira/browse/ARTEMIS-2409?focusedWorklogId=278271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278271
 ]

ASF GitHub Bot logged work on ARTEMIS-2409:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jul/19 15:33
            Start Date: 17/Jul/19 15:33
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #2742: 
ARTEMIS-2409 Convert HornetQ field names in consumer/queue selector s…
URL: https://github.com/apache/activemq-artemis/pull/2742#discussion_r304476612
 
 

 ##########
 File path: 
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/jms/client/SelectorTranslatorTest.java
 ##########
 @@ -204,6 +204,37 @@ public void testParseJMSType() {
       checkNoSubstitute("JMSType");
    }
 
+   @Test
 
 Review comment:
   The proper test would been on the compatibility-tests
   
   
   I have added it as part of my merge. just letting you know for future 
reference.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 278271)
    Time Spent: 20m  (was: 10m)

> HornetQ client vs Artemis broker compatibility: issue while using 
> JMSMessageID as selector
> ------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2409
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2409
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.9.0
>            Reporter: Tomas Hofman
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> When Hornetq client connects to Artemis broker, and creates consumer with 
> selector containing e.g. {{JMSMessageID}} field, selector fails to correctly 
> match messages.
> When using JMSMessageID as a selector, HornetQ client converts the header to 
> {{HQUserID}}, while Artemis is expecting header {{AMQUserID}}.
> The broker should detect a legacy HornetQ client and adjust the incoming 
> selector.
> {code}
> String selector = "JMSMessageID = 'ID:06df8801-9719-11e9-9313-972d6542d784'";
> // message with above ID exists in the queue
> org.hornetq.api.core.client.ClientConsumer hqConsumer = 
> hqSession.createConsumer(queueName, selector, true);
> org.hornetq.api.core.client.ClientMessage message = hqConsumer.receive(1000);
> assertNotNull(message); // fails
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to