[ 
https://issues.apache.org/jira/browse/ARTEMIS-2420?focusedWorklogId=279372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279372
 ]

ASF GitHub Bot logged work on ARTEMIS-2420:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jul/19 22:03
            Start Date: 18/Jul/19 22:03
    Worklog Time Spent: 10m 
      Work Description: michaelpearce-gain commented on pull request #2760: 
ARTEMIS-2420 Adding support for DLA/DLQ prefix for wildcard addresses
URL: https://github.com/apache/activemq-artemis/pull/2760#discussion_r305132333
 
 

 ##########
 File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml
 ##########
 @@ -377,6 +377,9 @@
       </security-settings>
 
       <address-settings>
+         <address-setting match="#">
+            <dead-letter-address-prefix>DLA.</dead-letter-address-prefix>
 
 Review comment:
   Why should it? As suggested in the case of new auto dla then maybe both 
settings are checked before a queue is created only if both are possible then 
you could craete queue and the dla. Security settings and address settings for 
the new dla match. I think this would be simplist way to avoid issue as then it 
avoids issues such as the dla address having a security setting or address 
setting match that dont allow creation (for the user when security)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 279372)
            Time Spent: 9h  (was: 8h 50m)
    Remaining Estimate: 3h  (was: 3h 10m)

> Reimplementation of AMQ5 dead letter strategy queuePrefix
> ---------------------------------------------------------
>
>                 Key: ARTEMIS-2420
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2420
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.9.0
>            Reporter: Piotr Klimczak
>            Priority: Major
>   Original Estimate: 12h
>          Time Spent: 9h
>  Remaining Estimate: 3h
>
> ActiveMQ Classic supports DLQ prefixes for dynamically created destinations.
> This causes regression when switching from AMQ5 to AMQ Artemis, therefore it 
> should be reimplemented.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to