[
https://issues.apache.org/jira/browse/ARTEMIS-2408?focusedWorklogId=279570&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279570
]
ASF GitHub Bot logged work on ARTEMIS-2408:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/19 08:01
Start Date: 19/Jul/19 08:01
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2759:
ARTEMIS-2408 Too many opened FDs after server stops
URL: https://github.com/apache/activemq-artemis/pull/2759#discussion_r305242382
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -1269,6 +1269,8 @@ void stop(boolean failoverOnServerShutdown, final
boolean criticalIOError, boole
this.analyzer = null;
}
+ activateCallbacks.clear();
Review comment:
So the fix should be in the component holding the external resource then.
Not here. If a piece of code opens an external resource the logic and lifecycle
of that must be managed by it properly. Seems this is just hiding the problem
that a component is not managing its rource correctly and simply this is hiding
that issur
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 279570)
Time Spent: 9h 20m (was: 9h 10m)
> Too many opened FDs after server stops
> --------------------------------------
>
> Key: ARTEMIS-2408
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2408
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Domenico Bruscino
> Priority: Major
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> The number of opened FDs after stop the server on the testsuite is much
> higher than the number before the server is started, when default netty
> configuration is used.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)