[
https://issues.apache.org/jira/browse/ARTEMIS-2494?focusedWorklogId=317872&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317872
]
ASF GitHub Bot logged work on ARTEMIS-2494:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/19 21:49
Start Date: 24/Sep/19 21:49
Worklog Time Spent: 10m
Work Description: k-wall commented on pull request #2847: ARTEMIS-2494:
[AMQP] Allow Modified disposition to be used signal address full to a sending
peer
URL: https://github.com/apache/activemq-artemis/pull/2847#discussion_r327849559
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java
##########
@@ -326,6 +325,37 @@ private void actualDelivery(Delivery delivery, Receiver
receiver, ReadableBuffer
}
}
+ private DeliveryState determineDeliveryState(final Source source, final
boolean useModified, final Exception e) {
+ Outcome defaultOutcome = getEffectiveDefaultOutcome(source);
+ if (e instanceof ActiveMQAddressFullException && useModified &&
+ (outcomeSupported(source, Modified.DESCRIPTOR_SYMBOL) ||
defaultOutcome instanceof Modified)) {
+ Modified modified = new Modified();
+ modified.setDeliveryFailed(true);
+ modified.setUndeliverableHere(false);
Review comment:
`undeliverable-here` is set false. only `delivery-failed` is set true. I
maybe missing your point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 317872)
Time Spent: 2h 20m (was: 2h 10m)
> Artemis responds with disposition Rejected if queue is full
> -----------------------------------------------------------
>
> Key: ARTEMIS-2494
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2494
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.10.0
> Reporter: Ulf Lilleengen
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> When a queue is full, Artemis will respond with disposition=Rejected. In
> certain situations, it is desirable to receive a Modified in this case, so
> that a client may re-queue the message for re-delivery (this is what Artemis
> does if consumers respond with released or modified for instance).
>
> The current behavior is determined by
> ProtonServerReceiverContext#actualDelivery . It would be great if this method
> could respond with Modified instead in the event of the exception being an
> ActiveMQAddressFullException.
>
> This behavior should probably be exposed as a configuration option to avoid
> breaking existing behavior.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
