[jira] [Work logged] (ARTEMIS-2503) Improve wildcards for the roles access match

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/ARTEMIS-2503?focusedWorklogId=327920&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327920
 ]

ASF GitHub Bot logged work on ARTEMIS-2503:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Oct/19 15:48
            Start Date: 14/Oct/19 15:48
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #2851: 
ARTEMIS-2503 Improve wildcards for the roles access match
URL: https://github.com/apache/activemq-artemis/pull/2851#discussion_r334547881
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/JMXAccessControlList.java
 ##########
 @@ -25,12 +25,22 @@
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 
+import org.apache.activemq.artemis.core.config.WildcardConfiguration;
+import org.apache.activemq.artemis.core.settings.HierarchicalRepository;
+import 
org.apache.activemq.artemis.core.settings.impl.HierarchicalObjectRepository;
+
 public class JMXAccessControlList {
 
    private Access defaultAccess = new Access("*");
-   private Map<String, Access> domainAccess = new HashMap<>();
+   private HierarchicalRepository<Access> domainAccess;
    private ConcurrentHashMap<String, List<String>> whitelist = new 
ConcurrentHashMap<>();
 
+   public JMXAccessControlList() {
+      WildcardConfiguration domainAccessWildcardConfiguration = new 
WildcardConfiguration();
 
 Review comment:
   @michaelandrepearce my personal opinion here: can't we keep this simple.. 
meaning. no configuration of wildcard for management?
   
   I see this can be useful on queues.. etc.. but on management, if we could 
keep it simple??
   
   I mean... management and broker should be kept independent.. I wouldn't load 
something from broker.xml to change semantics on management... 
   
   And if you require the wildcard configuration, then you need testing..and 
more moving parts bound to fail and document...
   
   I would prefer to keep it simpler?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 327920)
    Time Spent: 2h 10m  (was: 2h)

> Improve wildcards for the roles access match
> --------------------------------------------
>
>                 Key: ARTEMIS-2503
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2503
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Domenico Bruscino
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Please improve wildcard support for the key element in the roles access 
> <match> element.
> ATM you can NOT apply a restriction across a set of queue instances starting 
> with the same prefix (like below):
> {code:java}
> <match domain="org.apache.activemq.artemis" key="queue=my*">
>    <access method="list*" roles="group2"/>
>    <access method="get*" roles="group2"/>
>    ...
> </match>{code}
> If queues are created dynamically and only a queue name "prefix" is known in 
> advance; JMX RBAC cannot be used to restrict access in this case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)