[
https://issues.apache.org/jira/browse/ARTEMIS-2558?focusedWorklogId=347501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347501
]
ASF GitHub Bot logged work on ARTEMIS-2558:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/19 16:21
Start Date: 21/Nov/19 16:21
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2897:
ARTEMIS-2558 Add the commented out args to dump the java heap on OOME
URL: https://github.com/apache/activemq-artemis/pull/2897#discussion_r349182316
##########
File path:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
##########
@@ -112,6 +112,11 @@ if [ -z "$WILDFLY_COMMON" ] ; then
WILDFLY_COMMON="$ARTEMIS_HOME/lib/${wildfly-common}"
fi
+if [ -f "$ARTEMIS_INSTANCE/log/oomheapdump.hprof" ] ; then
Review comment:
Comment this as it something that should be opted into, also best to use a
var for the filename as everyone will have their own naming conventions
Lastly you may want to have a max history else you can easily fill disk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 347501)
Time Spent: 40m (was: 0.5h)
> Add the commented out args to dump the java heap on OOME
> --------------------------------------------------------
>
> Key: ARTEMIS-2558
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2558
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Bruscino
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Would it be possible to add -XX:+HeapDumpOnOutOfMemoryError
> -XX:HeapDumpPath=... to the broker jvm args (as commented out).
> When a broker hits an out of memory exception, the heap dump is required to
> investigate. It would be useful to have it generated on the first occurrence
> rather than setting the arg and waiting for a second occurrence.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
