[
https://issues.apache.org/jira/browse/ARTEMIS-2636?focusedWorklogId=401700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-401700
]
ASF GitHub Bot logged work on ARTEMIS-2636:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/20 19:19
Start Date: 11/Mar/20 19:19
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #3005:
ARTEMIS-2636: Introduce Disk Usage Metrics
URL: https://github.com/apache/activemq-artemis/pull/3005#discussion_r391205527
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -2996,6 +2996,7 @@ private void registerMeters() {
builder.register(BrokerMetricNames.CONNECTION_COUNT, this, metrics
-> Double.valueOf(getConnectionCount()),
ActiveMQServerControl.CONNECTION_COUNT_DESCRIPTION);
builder.register(BrokerMetricNames.TOTAL_CONNECTION_COUNT, this,
metrics -> Double.valueOf(getTotalConnectionCount()),
ActiveMQServerControl.TOTAL_CONNECTION_COUNT_DESCRIPTION);
builder.register(BrokerMetricNames.ADDRESS_MEMORY_USAGE, this,
metrics -> Double.valueOf(getPagingManager().getGlobalSize()),
ActiveMQServerControl.ADDRESS_MEMORY_USAGE_DESCRIPTION);
+ builder.register(BrokerMetricNames.DISK_STORE_USAGE, this, metrics
-> Double.valueOf(getPagingManager().getDiskTotalSpace() -
getPagingManager().getDiskUsableSpace()),
ActiveMQServerControl.DISK_STORE_USAGE_DESCRIPTION);
Review comment:
Typically the words used for disk reporting are used and free to avoid any
confusion.
Youre using the word usage which to me suggest its the used space not the
free
I would recommend we use clearer words like used and free
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 401700)
Time Spent: 5h 10m (was: 5h)
> Expose disk store used percentage metric
> ----------------------------------------
>
> Key: ARTEMIS-2636
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2636
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.11.0
> Reporter: Christoph Ewerlin
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> It would be very nice if the disk store used could be exposed via the metrics
> registry (preferably) and/or JMX like address.memory.usage already already is.
> In addition it would be nice to have percentage values for both
> address_memory_usage and disk_store_usage which would make setting up alarms
> much easier.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
