[
https://issues.apache.org/jira/browse/ARTEMIS-2692?focusedWorklogId=416222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-416222
]
ASF GitHub Bot logged work on ARTEMIS-2692:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/20 17:36
Start Date: 05/Apr/20 17:36
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on issue #3063:
ARTEMIS-2692 refactor queue creation
URL: https://github.com/apache/activemq-artemis/pull/3063#issuecomment-609453531
Could i suggest this PR is split in two. One with the refactor where tests
remain untouched. And the once that is merged and a full build with all tests
run not just the pr ones. Then a subsequent pr is raised to update tests.
Reason for this is that this is a sizeable refactor and even human eye
looking over may miss something. Where as we do expect if refactor all historic
tests should pass without modification. By having both refactor and tests
change its hard to get confidence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 416222)
Time Spent: 0.5h (was: 20m)
> Refactor queue creation
> -----------------------
>
> Key: ARTEMIS-2692
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2692
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The number of overloaded methods to create queues hurts broker usability and
> code maintainability. Queue creation should be refactored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
