[
https://issues.apache.org/jira/browse/AMQNET-565?focusedWorklogId=425170&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425170
]
ASF GitHub Bot logged work on AMQNET-565:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/20 00:32
Start Date: 20/Apr/20 00:32
Worklog Time Spent: 10m
Work Description: michaelandrepearce edited a comment on issue #9:
URL:
https://github.com/apache/activemq-nms-openwire/pull/9#issuecomment-616250391
@lrushl if your picking this up, first of all thanks, im sure @killnine will
appreciate.
- Unit tests
1.. Tests should be multi target both framework and core e.g.
`<TargetFrameworks>net462;netcoreapp2.2</TargetFrameworks>`
2.. DTC tests should be ignored when platform is CORE, but should run and
pass when on framework. When doing a full batch build, both should be built,
and both CORE and Framework tests should be run, we should ensure the ignore is
only when on CORE
3.. The 3 other failures should be fixed before this PR can merge, if you
believe they're pre existing i'm happy for it to be a separate PR (and Jira)
which gets merged first, or part of this PR.
- Protocol upgrade is out of scope, that should have its own JIRA and own
PR, and something that is done after this PR is done, this is kind of
foundational to get openwire client up to date, and re-releasable.
- Release / Package scripts, still need to be updated else, see
https://github.com/apache/activemq-nms-amqp/blob/master/package.ps1 as sample
of a more updated version that could be copied to here to replace existing....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 425170)
Time Spent: 13h (was: 12h 50m)
> Dotnet core port
> -----------------
>
> Key: AMQNET-565
> URL: https://issues.apache.org/jira/browse/AMQNET-565
> Project: ActiveMQ .Net
> Issue Type: New Feature
> Components: ActiveMQ
> Reporter: Wojtek Kulma
> Priority: Major
> Time Spent: 13h
> Remaining Estimate: 0h
>
> Apache.NMS.ActiveMQ should be ported for dotnet core.
> For now the following error is rises:
> D:\RiderProjects\syncro [master ≡ +1 ~1 -1 !]> dotnet add package
> Apache.NMS.ActiveMQ
> Microsoft (R) Build Engine version 15.1.1012.6693
> Copyright (C) Microsoft Corporation. All rights reserved.
> Writing C:\Users\wkulma\AppData\Local\Temp\tmp9A2E.tmp
> info : Adding PackageReference for package 'Apache.NMS.ActiveMQ' into project
> 'D:\RiderProjects\syncro\syncro.fsproj'.
> log : Restoring packages for D:\RiderProjects\syncro\syncro.fsproj...
> info : GET
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/index.json
> info : CACHE https://api.nuget.org/v3-flatcontainer/fsharp.core/index.json
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.core/4.1.17/fsharp.core.4.1.17.nupkg
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.net.sdk/index.json
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.net.sdk/1.0.5/fsharp.net.sdk.1.0.5.nupkg
> info : OK
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/index.json 611ms
> info : GET
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/1.7.2/apache.nms.activemq.1.7.2.nupkg
> info : OK
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/1.7.2/apache.nms.activemq.1.7.2.nupkg
> 481ms
> error: Package Apache.NMS.ActiveMQ 1.7.2 is not compatible with netcoreapp1.1
> (.NETCoreApp,Version=v1.1). Package Apache.NMS.ActiveMQ 1.7.2 supports:
> error: - net20 (.NETFramework,Version=v2.0)
> error: - net35 (.NETFramework,Version=v3.5)
> error: - net40 (.NETFramework,Version=v4.0)
> error: Package Apache.NMS 1.7.1 is not compatible with netcoreapp1.1
> (.NETCoreApp,Version=v1.1). Package Apache.NMS 1.7.1 supports:
> error: - net20 (.NETFramework,Version=v2.0)
> error: - net20-cf (.NETFramework,Version=v2.0,Profile=CompactFramework)
> error: - net35 (.NETFramework,Version=v3.5)
> error: - net40 (.NETFramework,Version=v4.0)
> error: One or more packages are incompatible with .NETCoreApp,Version=v1.1.
> error: Package 'Apache.NMS.ActiveMQ' is incompatible with 'all' frameworks in
> project 'D:\RiderProjects\syncro\syncro.fsproj'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
