[ https://issues.apache.org/jira/browse/ARTEMIS-2793?focusedWorklogId=441279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441279 ]
ASF GitHub Bot logged work on ARTEMIS-2793: ------------------------------------------- Author: ASF GitHub Bot Created on: 04/Jun/20 13:41 Start Date: 04/Jun/20 13:41 Worklog Time Spent: 10m Work Description: franz1981 commented on a change in pull request #3167: URL: https://github.com/apache/activemq-artemis/pull/3167#discussion_r435263280 ########## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumVoteServerConnect.java ########## @@ -141,7 +141,11 @@ public synchronized Boolean getDecision() { return votesNeeded == 0; } - public void await(int latchTimeout, TimeUnit unit) throws InterruptedException { + public void await(int latchTimeout, TimeUnit unit, int maxClusterSize) throws InterruptedException { Review comment: IMO this check should be moved into `QuorumManager`, given that: - `maxClusterSize` is already owned and managed by it - QuorumVoteServerConnect isn't aware of how many cluster members could perform the vote, just the expected number to unblock the quorum ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 441279) Time Spent: 0.5h (was: 20m) > quorum logging implies it happens when single pair > -------------------------------------------------- > > Key: ARTEMIS-2793 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2793 > Project: ActiveMQ Artemis > Issue Type: Bug > Reporter: Andy Taylor > Assignee: Andy Taylor > Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > we should probably log something different so users know no voting occured -- This message was sent by Atlassian Jira (v8.3.4#803005)