[ 
https://issues.apache.org/jira/browse/ARTEMIS-2787?focusedWorklogId=441642&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441642
 ]

ASF GitHub Bot logged work on ARTEMIS-2787:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jun/20 02:17
            Start Date: 05/Jun/20 02:17
    Worklog Time Spent: 10m 
      Work Description: michaelpearce-gain commented on a change in pull 
request #3169:
URL: https://github.com/apache/activemq-artemis/pull/3169#discussion_r435653023



##########
File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/addressing/AddressingTest.java
##########
@@ -268,6 +268,62 @@ public void testPurgeOnNoConsumersFalse() throws Exception 
{
       Wait.assertEquals(1, server.locateQueue(queueName)::getMessageCount);
    }
 
+
+   @Test
+   public void testQueueEnabledDisabled() throws Exception {

Review comment:
       @clebertsuconic see here this is the actual functionality test, where 
enabling / disabling the queue, and affects the behaviour (E.g. disables the 
actual queue receiving messages)
   
   other tests in the PR (which is probably what caused you to think there was 
no effect on the queue) were added are just around checking config works and 
updates etc should reload config etc occur. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 441642)
    Time Spent: 3h  (was: 2h 50m)

> Allow a queue to be disabled, so that messages are not routed to it.
> --------------------------------------------------------------------
>
>                 Key: ARTEMIS-2787
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2787
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: Michael Andre Pearce
>            Priority: Major
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> There are a number of scenarios where it can be useful to disable a queue, so 
> messages are not routed to it.
> 1) An issue that requires investigation but you wish to keep the consumers 
> active, but do not wish to have message build up on the broker
>  
> 2) you want to connect consumers to a address, but you do not wish the flow 
> to start and wish to manage the enablement and disablement centrally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to