[
https://issues.apache.org/jira/browse/ARTEMIS-2801?focusedWorklogId=444404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444404
]
ASF GitHub Bot logged work on ARTEMIS-2801:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/20 17:18
Start Date: 11/Jun/20 17:18
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #3177:
URL: https://github.com/apache/activemq-artemis/pull/3177#issuecomment-642820835
Doesn't this mean that the "human readable format" won't be formatted
according to the JVM's default locale? It seems like this is the opposite of
what we want. Wouldn't we want to change the *test* so that it formats the
assertion value according to the default locale?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 444404)
Time Spent: 40m (was: 0.5h)
> Fix ByteUtil.getHumanReadableByteCount() giving inconsistent results
> --------------------------------------------------------------------
>
> Key: ARTEMIS-2801
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2801
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Tests
> Environment: Windows 10 with cs-CZ locale.
> Reporter: Jan Šmucr
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 2.14.0
>
> Original Estimate: 10m
> Time Spent: 40m
> Remaining Estimate: 0h
>
> HumanReadableByteCountTest test fails in environments with different locale.
> {code:java}
> org.junit.ComparisonFailure:
> Expected :999.0B
> Actual :999,0B
> <Click to see difference>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.activemq.artemis.utils.HumanReadableByteCountTest.test(HumanReadableByteCountTest.java:31)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
