[
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=455185&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455185
]
ASF GitHub Bot logged work on ARTEMIS-2797:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/20 01:47
Start Date: 07/Jul/20 01:47
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3213:
URL: https://github.com/apache/activemq-artemis/pull/3213#discussion_r450566421
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -701,7 +701,7 @@ public QueueBinding updateQueue(QueueConfiguration
queueConfiguration, boolean f
final SimpleString empty = new SimpleString("");
Filter oldFilter = FilterImpl.createFilter(queue.getFilter() ==
null ? empty : queue.getFilter().getFilterString());
Filter newFilter =
FilterImpl.createFilter(queueConfiguration.getFilterString() == null ? empty :
queueConfiguration.getFilterString());
- if ((forceUpdate || newFilter != null) &&
!Objects.equals(oldFilter, newFilter)) {
+ if ((forceUpdate || newFilter != oldFilter) &&
!Objects.equals(oldFilter, newFilter)) {
Review comment:
@jsmucr here is the change that should fix the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 455185)
Time Spent: 7h 10m (was: 7h)
> Reset queue properties by unsetting them in broker.xml
> ------------------------------------------------------
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.13.0
> Reporter: Jan Šmucr
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.14.0
>
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> Currently the queue properties cannot be removed because of property new
> value null checks leading to quitting the PostOfficeImpl#updateQueue()
> instead of resetting the properties to their default values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
