[ https://issues.apache.org/jira/browse/ARTEMIS-2953?focusedWorklogId=502193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-502193 ]
ASF GitHub Bot logged work on ARTEMIS-2953: ------------------------------------------- Author: ASF GitHub Bot Created on: 19/Oct/20 13:36 Start Date: 19/Oct/20 13:36 Worklog Time Spent: 10m Work Description: gtully commented on pull request #3305: URL: https://github.com/apache/activemq-artemis/pull/3305#issuecomment-712161187 fmi: a case where the finalize kicks in from the 14 build, that test still needs some clean up: java.lang.Error: Finalize is doing close work on: Page::pageNr=129, file=FakeSequentialFile:000000129.page at org.apache.activemq.artemis.core.paging.impl.Page.finalize(Page.java:594) at java.base/java.lang.System$2.invokeFinalize(System.java:2190) at java.base/java.lang.ref.Finalizer.runFinalizer(Finalizer.java:87) at java.base/java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:171) Caused by: java.lang.Throwable: Thread[Thread-6121,5,main] at org.apache.activemq.artemis.core.paging.impl.Page.open(Page.java:485) at org.apache.activemq.artemis.core.paging.impl.PagingStoreImpl.openNewPage(PagingStoreImpl.java:1122) at org.apache.activemq.artemis.core.paging.impl.PagingStoreImpl.page(PagingStoreImpl.java:859) at org.apache.activemq.artemis.tests.unit.core.paging.impl.PagingStoreImplTest$1WriterThread.run(PagingStoreImplTest.java:426) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 502193) Time Spent: 40m (was: 0.5h) > Page.finalize causing intermittent test failures > ------------------------------------------------ > > Key: ARTEMIS-2953 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2953 > Project: ActiveMQ Artemis > Issue Type: Bug > Affects Versions: 2.15.0 > Reporter: Gary Tully > Assignee: Gary Tully > Priority: Major > Fix For: 2.16.0 > > Time Spent: 40m > Remaining Estimate: 0h > > I see two intermittent failures in the PR build jobs: > * PageTest.testDamagedPage:115->testDamagedPage:230 » IllegalState Is closed > Error: > * PagingStoreImplTest.testConcurrentDepage:372->testConcurrentPaging:554 » > IllegalState > > Both seem to result from concurrent calls to close via the Page.finalize > finalize is hugely non deterministic, it should go. It may be that we need > some more calls to close, lets see. > note: both those tests use FakeSequentialFileFactory but I don't think the > problem is in that. -- This message was sent by Atlassian Jira (v8.3.4#803005)