[
https://issues.apache.org/jira/browse/ARTEMIS-2937?focusedWorklogId=504181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504181
]
ASF GitHub Bot logged work on ARTEMIS-2937:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/20 14:10
Start Date: 23/Oct/20 14:10
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3294:
URL: https://github.com/apache/activemq-artemis/pull/3294#discussion_r510910934
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -752,31 +771,31 @@ protected ReadableBuffer
createCopyWithNewDeliveryCount(int deliveryCount) {
// otherwise we want to write the original header if present. When a
// Header is present we need to copy it as we are updating the
re-delivered
// message and not the stored version which we don't want to invalidate
here.
- Header header = this.header;
- if (header == null) {
- header = new Header();
+ Header localHeader = this.header;
+ if (localHeader == null) {
+ localHeader = new Header();
} else {
- header = new Header(header);
+ localHeader = new Header(header);
}
- header.setDeliveryCount(UnsignedInteger.valueOf(amqpDeliveryCount));
+ localHeader.setDeliveryCount(UnsignedInteger.valueOf(amqpDeliveryCount));
TLSEncode.getEncoder().setByteBuffer(new NettyWritable(result));
- TLSEncode.getEncoder().writeObject(header);
+ TLSEncode.getEncoder().writeObject(localHeader);
Review comment:
I don't think it's a big deal TBH.. on my usages there will always be a
header when there is a delivery annotation to be used.
it's simple enough to do it though...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 504181)
Time Spent: 19h 10m (was: 19h)
> AMQP Server Connectivity
> ------------------------
>
> Key: ARTEMIS-2937
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2937
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 19h 10m
> Remaining Estimate: 0h
>
> This feature adds server side connectivity.
>
> It is possible to link two brokers directly using AMQP with this feature, and
> have a Queue transferring messages to another broker directly.
>
> For this we would have options called <sender and <receiver
>
>
> it would also be possible to use qpid-dispatch as an intermediary between
> clients and the brokers (or eventually between brokers), on that case the
> option will be <peer
>
> it would also be possible to use <mirror with a few option to replicate data
> between two brokers, bringing the possibility of using it for Disaster &
> Recovery and Failover.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
