[
https://issues.apache.org/jira/browse/ARTEMIS-2990?focusedWorklogId=514693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514693
]
ASF GitHub Bot logged work on ARTEMIS-2990:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/20 16:31
Start Date: 20/Nov/20 16:31
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3352:
URL: https://github.com/apache/activemq-artemis/pull/3352#discussion_r527809669
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/AddressImpl.java
##########
@@ -84,6 +84,7 @@ public void addLinkedAddress(final Address address) {
if (linkedAddresses == null) {
linkedAddresses = PlatformDependent.hasUnsafe() ? new
NonBlockingHashSet<>() : new ConcurrentHashSet<>();
}
+ assert !linkedAddresses.contains(address);
Review comment:
But that is at risk at causing a runtime issue in real systems. If you
want to validate it, as noted and as per general collection kind of behaviour
its normal to return true false if a change occured not error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 514693)
Time Spent: 5h 20m (was: 5h 10m)
> optimise performance of wildcard address manager
> ------------------------------------------------
>
> Key: ARTEMIS-2990
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2990
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.16.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> A scenario test with lots of short lived concurrent wildcard subs
> demonstrates some bottlenecks in the wildcard address and binding manager.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
