[
https://issues.apache.org/jira/browse/ARTEMIS-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278191#comment-17278191
]
ASF subversion and git services commented on ARTEMIS-3081:
----------------------------------------------------------
Commit 044d6101e94f338907f90651387041f10aad9896 in activemq-artemis's branch
refs/heads/master from Ingo Karkat
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=044d610 ]
ARTEMIS-3081 Swap precedence of key/tr.store props
If an application wants to use a special key/truststore for Artemis but
have the remainder of the application use the default Java store, the
org.apache.activemq.ssl.keyStore needs to take precedence over Java's
javax.net.ssl.keyStore. However, the current implementation takes the
first non-null value from
System.getProperty(JAVAX_KEYSTORE_PATH_PROP_NAME),
System.getProperty(ACTIVEMQ_KEYSTORE_PATH_PROP_NAME),
keyStorePath
So if the default Java property is set, no override is possible. Swap
the order of the JAVAX_... and ACTIVEMQ_... property names so that the
ActiveMQ ones come first (as a component-specific overrides), the
standard Java ones comes second, and finally a local attribute value
(through Stream.of(...).firstFirst()).
(In our case the application uses the default Java truststore location
at $JAVA_HOME/lib/security/jssecacerts, and only supplies its password
in javax.net.ssl.trustStorePassword, and then uses a dedicated
truststore for Artemis. Defining both org.apache.activemq.ssl.trustStore
and org.apache.activemq.ssl.trustStorePassword now makes Artemis use the
dedicated truststore (javax.net.ssl.trustStore is not set as we use the
default location, so the second choice
org.apache.activemq.ssl.trustStore applies), but with the Java default
truststore password (first choice javax.net.ssl.trustStorePassword
applies instead of the second choice because it is set for the default
truststore). Obviously, this does not work unless both passwords are
identical!)
> Cannot override the default Java key/truststore properties
> ----------------------------------------------------------
>
> Key: ARTEMIS-3081
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3081
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.5.0, 2.16.0
> Environment: In our case the application uses the default Java
> truststore location at {{$JAVA_HOME/lib/security/jssecacerts}}, and only
> supplies its password in {{javax.net.ssl.trustStorePassword}}, and then uses
> a dedicated truststore for Artemis. Defining both
> {{org.apache.activemq.ssl.trustStore}} and
> {{org.apache.activemq.ssl.trustStorePassword}} now makes Artemis use the
> dedicated truststore ({{javax.net.ssl.trustStore}} is not set as we use the
> default location, so the second choice
> {{org.apache.activemq.ssl.trustStore}} applies), but with the Java default
> truststore password (first choice {{javax.net.ssl.trustStorePassword}}
> applies instead of the second choice because it is set for the default
> truststore). Obviously, this does not work unless both passwords are
> identical!
> Reporter: Ingo Karkat
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> If an application wants to use a special key/truststore for Artemis but have
> the remainder of the application use the default Java store, the
> {code:java}
> org.apache.activemq.ssl.keyStore{code}
> needs to take precedence over Java's
> {code:java}
> javax.net.ssl.keyStore{code}
> However, the current implementation takes the first non-null value from
> {code:java}
> System.getProperty(JAVAX_KEYSTORE_PATH_PROP_NAME)
> System.getProperty(ACTIVEMQ_KEYSTORE_PATH_PROP_NAME)
> keyStorePath{code}
> So if the default Java property is set, no override is possible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
