[
https://issues.apache.org/jira/browse/AMQ-7052?focusedWorklogId=562241&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-562241
]
ASF GitHub Bot logged work on AMQ-7052:
---------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/21 09:07
Start Date: 08/Mar/21 09:07
Worklog Time Spent: 10m
Work Description: lucastetreault removed a comment on pull request #298:
URL: https://github.com/apache/activemq/pull/298#issuecomment-792580290
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 562241)
Time Spent: 20m (was: 10m)
> Fix tests related to purgeRecoveredXATransactions property on the KahaDB
> ------------------------------------------------------------------------
>
> Key: AMQ-7052
> URL: https://issues.apache.org/jira/browse/AMQ-7052
> Project: ActiveMQ
> Issue Type: Test
> Components: Test Cases
> Affects Versions: 5.15.5, 5.15.6
> Reporter: Alan Protasio
> Assignee: Gary Tully
> Priority: Minor
> Fix For: 5.16.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Fix the following tests:
> JdbcXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332
> expected:<0> but was:<4>
> JdbcXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeCommitOnRestart:391
> null
> mKahaDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332
> expected:<0> but was:<4>
> mKahaDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeCommitOnRestart:391
> null
> mLevelDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332
> expected:<0> but was:<4>
> Those tests are failing because this feature (purge transactions after
> reboot) was only implemented on the KahaDBPersistenceAdapter.
> [https://github.com/apache/activemq/commit/ce7498c971b99e2515f07aab36418a1a0f19c03e]
> The tests are failing because the class XARecoveryBrokerTest is used to test
> multiples adapters that are not implementing the same feature.
> Steps to reproduce:
> > git checkout [https://github.com/apache/activemq/tree/activemq-5.15.x]
> > cd activemq-unit-tests
> > mvn clean install -Dtest=JdbcXARecoveryBrokerTest
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
