[
https://issues.apache.org/jira/browse/ARTEMIS-3106?focusedWorklogId=570395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570395
]
ASF GitHub Bot logged work on ARTEMIS-3106:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/21 12:28
Start Date: 23/Mar/21 12:28
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3470:
URL: https://github.com/apache/activemq-artemis/pull/3470#discussion_r599522161
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/scram/SCRAM.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.spi.core.security.scram;
+
+/**
+ * Defines sets of known SCRAM types with methods to fetch matching digest and
hmac names
+ */
+public enum SCRAM {
+ SHA1,
+ SHA256,
+ SHA512;
Review comment:
>>For me adding a sasl-client implementation in the context that there
is no AMQP-Client I'm aware of that support SHA-512 (yet) is at least too much
hassle.
My earlier comments about unit tests were about all the supported mechs, the
point on the SHA-512 specifically was just that it would have then actually had
some tests and could have remained (since the tests would after all be rather
common, differing in the algorithm used and some expected values, i.e a likely
trivial amount of additional effort).
> Artemis includes a JMS client but I can't find how it is used, is there an
example that uses AMQP+SASL+Artemis JMS Client?
There are vast numbers of examples (see the examples dir) and tests showing
how the Artemis JMS client can be used, so I assume its something more nuanced
you are asking? I'd note though that Artemis JMS client uses Artemis' own Core
protocol, which doesnt support SASL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 570395)
Time Spent: 11h 20m (was: 11h 10m)
> Support for SASL-SCRAM
> ----------------------
>
> Key: ARTEMIS-3106
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3106
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP
> Reporter: Christoph Läubrich
> Priority: Major
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> With the enhancements in ARTEMIS-33 / [PR
> 3432|https://github.com/apache/activemq-artemis/pull/3432] it would be now
> possible to plug-in new SASL mechanism.
> One popular one is
> [SASL-SCRAM|https://en.wikipedia.org/wiki/Salted_Challenge_Response_Authentication_Mechanism]
> because it allows channelbinding together with secure storage of
> user-credential.
> I have created an [implementation of this for Artemis
> AMQP|https://github.com/laeubi/scram-sasl/tree/artemis/artemis] based on the
> [SCRAM SASL authentication for Java|https://github.com/ogrebgr/scram-sasl]
> code with some enhancements/cleanups to the original.
> As the source is already Apache licensed I'd like to propose to include this
> in the Artemis code-base. This would greatly enhance the interoperability
> with other implementations e.g. Apache QPID.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
